Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix points edit with textentry #153

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

PeenScreeker
Copy link
Member

This PR fixes an issue with the new pano zoning UI. Points can now be edited after placement with the textentry panels for the respective point.

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

@PeenScreeker
Copy link
Member Author

@Panzerhandschuh do you want to give this a test drive, or is it good to merge?

@PeenScreeker PeenScreeker merged commit db66c2d into feat/mom-0.10 Sep 25, 2024
1 check passed
@PeenScreeker PeenScreeker deleted the fix/region-points branch September 25, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants